Pull Request Process

​

Overview

​

Before You Start

1. Read the Contributing Guidelines
2. Ensure your development environment is set up correctly
3. Follow the Code Style Guide
4. Test your changes thoroughly

​

Pull Request Template

​

What does this PR do?

## What does this PR do?

Adds support for custom block rendering with transparency effects.

​

Why?

## Why?

Transparent blocks were not rendering correctly in certain lighting 
conditions, causing visual artifacts. This fix ensures proper alpha 
blending for all transparent block types.

​

How to test

## How to test
- [ ] Place glass blocks in various lighting conditions
- [ ] Verify water renders correctly behind glass
- [ ] Check that stained glass colors display properly
- [ ] Test in both day and night cycles

​

Screenshots / Videos

## Screenshots / Videos

![Before](url-to-before-image)
![After](url-to-after-image)

​

Testing Checklist

# Build the solution in Visual Studio
# or use MSBuild from command line
msbuild MinecraftConsoles.sln /p:Configuration=Release

​

Submission Guidelines

​

Code Requirements

​

Creating the Pull Request

git checkout -b feature/my-new-feature
# or
git checkout -b fix/bug-description

git add .
git commit -m "Add transparency support for custom blocks"

git push origin feature/my-new-feature

​

Review Process

​

What Reviewers Look For

1. Functionality: Does it work as described?
2. Code Quality: Is the code well-written and maintainable?
3. Style Compliance: Does it follow the code style guide?
4. Testing: Has it been adequately tested?
5. Documentation: Are comments clear and helpful?
6. Impact: Does it affect other parts of the codebase?

​

Addressing Feedback

1. Respond promptly: Address comments in a timely manner
2. Ask questions: If feedback is unclear, ask for clarification
3. Make changes: Update your code based on feedback
4. Push updates: Push new commits to the same branch
5. Mark resolved: Mark conversation threads as resolved when addressed

# After making changes based on feedback
git add .
git commit -m "Address review feedback: improve error handling"
git push origin feature/my-new-feature

​

Automated Checks

• Build verification: Ensures code compiles
• Warning detection: Checks for new compiler warnings
• Code analysis: Static analysis for common issues

​

Merging Criteria

• ✅ All checklist items are completed
• ✅ Code builds without errors
• ✅ No new warnings introduced
• ✅ Tested in-game successfully
• ✅ Code review approved by maintainer(s)
• ✅ All automated checks pass
• ✅ Conflicts resolved (if any)

​

After Merging

1. Delete your branch (optional but recommended):
   git branch -d feature/my-new-feature
   git push origin --delete feature/my-new-feature
   
2. Update your local repository:
   git checkout main
   git pull origin main
   
3. Celebrate: Your contribution is now part of the project!

​

Common Issues

​

Merge Conflicts

# Update your branch with latest main
git checkout main
git pull origin main
git checkout feature/my-new-feature
git merge main

# Resolve conflicts, then:
git add .
git commit -m "Resolve merge conflicts"
git push origin feature/my-new-feature

​

Failed Builds

1. Check the build logs for errors
2. Reproduce the build locally
3. Fix the issues
4. Push the fixes

​

Stale PRs

• Rebase on the latest main branch
• Verify everything still works
• Ping reviewers if needed

​

Best Practices

​

Questions?

• Check existing PRs for examples
• Ask in the repository discussions
• Reach out to maintainers