Issue Tracking
All enhancement, bugfix, or change requests must begin with the creation of an Alpamayo 1 Issue Request.The issue request must be reviewed by Alpamayo 1 researchers and approved prior to code review.
Coding Guidelines
Code Style and Formatting
Please follow the existing conventions in the relevant file, submodule, module, and project when you add new code or when you extend/fix existing functionality. To maintain consistency in code formatting and style, you should also runpre-commit format on the modified sources with the provided configuration file. This applies Alpamayo 1 code formatting rules to:
- Class, function/method, and variable/field naming
- Comment style
- Indentation
- Line length
Best Practices
- Avoid introducing unnecessary complexity into existing code so that maintainability and readability are preserved.
-
Try to keep pull requests (PRs) as concise as possible:
- Avoid committing commented-out code.
- Wherever possible, each PR should address a single concern. If there are several otherwise-unrelated things that should be fixed to reach a desired endpoint, our recommendation is to open several PRs and indicate the dependencies in the description. The more complex the changes are in a single PR, the more time it will take to review those changes.
Commit Guidelines
Write commit titles using imperative mood and these rules, and reference the Issue number corresponding to the PR. Following is the recommended format for commit texts:Quality Requirements
- Ensure that the build log is clean, meaning no warnings or errors should be present.
- Ensure that all tests pass prior to submitting your code.
- All OSS components must contain accompanying documentation (READMEs) describing the functionality, dependencies, and known issues.
- See
README.mdfor existing samples and plugins for reference.
- See
- All OSS components must have an accompanying test.
- If introducing a new component, provide a test sample to verify the functionality.
- Make sure that you can contribute your work to open source (no license and/or patent conflict is introduced by your code). You will need to sign your commit.
Thanks in advance for your patience as we review your contributions; we do appreciate them!
Pull Requests
Developer workflow for code contributions is as follows:1. Fork the Repository
Developers must first fork the upstream Alpamayo 1 OSS repository.2. Clone and Push Changes
Git clone the forked repository and push changes to the personal fork.3. Create a Pull Request
Once the code changes are staged on the fork and ready for review, a Pull Request (PR) can be requested to merge the changes from a branch of the fork into a selected branch of upstream.- Creation of a PR kicks off the code review process.
- At least one Alpamayo 1 researcher will be assigned for the review.
- While under review, mark your PRs as work-in-progress by prefixing the PR title with
[WIP].
4. Testing and Acceptance
Since there is no CI/CD process in place yet, the PR will be accepted and the corresponding issue closed only after adequate testing has been completed, manually, by the developer and/or Alpamayo 1 researcher reviewing the code.Signing Your Work
We require that all contributors “sign-off” on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. To sign off on a commit you simply use the--signoff (or -s) option when committing your changes: