Bug Fix with Diagnostic Blueprint

[INFO] task="fix crash: bot panics when..." classified as BugFix (keyword match)

claude -p "Generate a 3-6 word git branch slug for this task..."
# Output: fix-empty-message-panic

git checkout -b magpie/fix-empty-message-panic

find /workspace/magpie -type f \
  -not -path '*/.git/*' \
  -not -path '*/target/*' \
  -not -path '*/node_modules/*'

...
/workspace/magpie/crates/magpie-discord/src/handler.rs
/workspace/magpie/crates/magpie-discord/src/main.rs
/workspace/magpie/crates/magpie-core/src/pipeline.rs
...

You are investigating a bug. The file tree of the repository is 
provided as previous step output.

Bug report: fix crash: bot panics when someone mentions it with no message

Stack trace:
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` 
on a `None` value'
crates/magpie-discord/src/handler.rs:47:52

Your job is to find the ROOT CAUSE. Do NOT plan a fix yet. 
Do NOT modify any files.

Instructions:
1. Trace the data flow through the affected code path
2. Read the relevant source files
3. Identify the exact location where behavior diverges from expectation
4. Name the specific files, functions, and line numbers involved
5. Explain WHY the bug occurs (not just WHAT happens)

Output a clear investigation report with your findings.

// handler.rs:42-50
pub async fn handle_mention(ctx: &Context, msg: &Message) -> Result<()> {
    let bot_id = ctx.cache.current_user().id;
    let content = msg.content.strip_prefix(&format!("<@{}>", bot_id));
    
    // Line 47 — THE PANIC
    let task = content.unwrap().trim();
    
    if task.is_empty() {
        return Ok(()); // early return for empty tasks
    }
    ...

ROOT CAUSE IDENTIFIED:

File: crates/magpie-discord/src/handler.rs
Function: handle_mention()
Line: 47

Problem:
The code calls .unwrap() on the result of strip_prefix(), which returns 
Option<&str>. When a user mentions the bot with NO text after the mention 
(e.g., just "@magpie"), strip_prefix() returns Some(""), but if the 
message format is unexpected or the prefix doesn't match exactly, it 
returns None.

The .unwrap() panics when None is returned.

Data flow:
1. Discord message: "@magpie" (no text after mention)
2. msg.content = "<@123456789>"
3. strip_prefix("<@123456789>") returns Some("")
4. BUT: If there's any whitespace or formatting difference, returns None
5. .unwrap() panics on None

Why it happens:
Discord's mention format can vary (with/without nickname syntax: 
<@!123> vs <@123>). The code only handles one format.

Affected code path:
- Discord event: MessageCreate
- handler.rs:handle_mention() line 47
- Panic occurs before any task validation

Additional context:
Line 48 checks if task.is_empty(), but we never reach that check because 
the unwrap() panics first when strip_prefix returns None.

Based on the investigation findings from the previous step, plan a 
targeted fix.

Bug report: fix crash: bot panics when...

Create a brief plan:
1. What is the root cause (from investigation)
2. What specific changes to make and why
3. What regression test to write

Fix Plan:

1. Root cause:
   The code calls .unwrap() on strip_prefix() result at line 47, which 
   panics when the mention format doesn't match (e.g., <@!123> vs <@123>).

2. Specific changes:
   a) Replace .unwrap() with proper Option handling using match or if-let
   b) Handle BOTH mention formats: <@123> and <@!123> (nickname syntax)
   c) Return early with Ok(()) when no valid task is extracted
   d) Keep the existing empty-task check

3. Regression test:
   - test_handle_mention_with_no_text() — send "<@bot_id>" with no text
   - test_handle_mention_nickname_syntax() — send "<@!bot_id>" format
   - test_handle_mention_with_whitespace() — send "<@bot_id>   " 
   Both should return Ok(()) without panicking.

Based on the plan from the previous step, write a regression test 
that REPRODUCES the bug.

Rules:
- The test should FAIL with the current (buggy) code
- It should PASS once the fix is applied
- Use the project's existing test patterns and framework
- Do NOT implement the fix yet — only the test

// crates/magpie-discord/src/handler.rs (added to #[cfg(test)] mod tests)

#[tokio::test]
async fn test_handle_mention_no_text_no_panic() {
    // Simulate a mention with no text after it
    let ctx = mock_context();
    let mut msg = mock_message();
    msg.content = "<@123456789>".to_string(); // bot ID, no text
    
    // Should NOT panic
    let result = handle_mention(&ctx, &msg).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_handle_mention_nickname_syntax() {
    // Discord nickname mention format: <@!123> instead of <@123>
    let ctx = mock_context();
    let mut msg = mock_message();
    msg.content = "<@!123456789> some task".to_string();
    
    // Should NOT panic and should extract "some task"
    let result = handle_mention(&ctx, &msg).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_handle_mention_whitespace_only() {
    let ctx = mock_context();
    let mut msg = mock_message();
    msg.content = "<@123456789>   ".to_string(); // only whitespace
    
    // Should return Ok without starting pipeline
    let result = handle_mention(&ctx, &msg).await;
    assert!(result.is_ok());
}

Regression tests written. Created 3 test functions:
- test_handle_mention_no_text_no_panic
- test_handle_mention_nickname_syntax
- test_handle_mention_whitespace_only

These will FAIL (panic) with the current code because of the unwrap() on line 47.

cargo test

running 3 tests
test test_handle_mention_no_text_no_panic ... FAILED
test test_handle_mention_nickname_syntax ... FAILED
test test_handle_mention_whitespace_only ... FAILED

failures:

---- test_handle_mention_no_text_no_panic stdout ----
thread 'test_handle_mention_no_text_no_panic' panicked at 
'called `Option::unwrap()` on a `None` value', 
crates/magpie-discord/src/handler.rs:47:52

---- test_handle_mention_nickname_syntax stdout ----
thread 'test_handle_mention_nickname_syntax' panicked at 
'called `Option::unwrap()` on a `None` value', 
crates/magpie-discord/src/handler.rs:47:52

test result: FAILED. 0 passed; 3 failed

[INFO] step="verify-test-fails" exit_code=101 (expected failure)

The regression test from the previous step has been run. The output 
(including failures) is provided as previous step output.

Bug report: fix crash: bot panics when...

Now fix the ROOT CAUSE identified in the investigation step.
- Do NOT use workarounds or band-aids
- Fix the underlying issue, not just the symptoms
- Make sure the regression test passes
- Do not break existing tests

// crates/magpie-discord/src/handler.rs:42-55 (FIXED)
pub async fn handle_mention(ctx: &Context, msg: &Message) -> Result<()> {
    let bot_id = ctx.cache.current_user().id;
    let content = &msg.content;
    
    // Handle both mention formats: <@123> and <@!123> (nickname)
    let task = if let Some(text) = content.strip_prefix(&format!("<@{}>", bot_id)) {
        text.trim()
    } else if let Some(text) = content.strip_prefix(&format!("<@!{}>", bot_id)) {
        text.trim()
    } else {
        // Not a valid mention — return early
        return Ok(());
    };
    
    if task.is_empty() {
        info!(user = %msg.author.name, "mention with no task — ignoring");
        return Ok(()); // early return for empty tasks
    }
    
    // Continue with pipeline...
    let user = msg.author.name.clone();
    let channel_id = msg.channel_id.to_string();
    
    info!(user = %user, task = %task, "received task");
    // ... rest of handler

Fix implemented:
- Removed .unwrap() on line 47
- Replaced with if-let chain handling both mention formats
- <@123> (standard) and <@!123> (nickname syntax)
- Returns Ok(()) early if no valid mention found
- Added logging for empty-task case
- All regression tests should now pass

cargo test

running 6 tests
test test_handle_mention_no_text_no_panic ... ok
test test_handle_mention_nickname_syntax ... ok
test test_handle_mention_whitespace_only ... ok
test test_handle_mention_with_task ... ok (existing test)
test test_create_thread ... ok (existing test)
test test_archive_thread ... ok (existing test)

test result: ok. 6 passed; 0 failed; 0 ignored

[INFO] step="run-tests" exit_code=0 tests passed

cargo clippy -- -D warnings

Checking magpie-discord v0.1.0
Finished dev [unoptimized + debuginfo] target(s) in 2.87s

[INFO] step="lint-check" exit_code=0 lint passed

[INFO] TDD tests+lint passed inside blueprint — skipping CI round 1

claude -p "Generate a conventional commit message from this diff..."
# Output: fix: handle Discord nickname mentions without panicking

git add crates/magpie-discord/src/handler.rs
git commit -m "fix: handle Discord nickname mentions without panicking"
git push -u origin magpie/fix-empty-message-panic
gh pr create --title "Fix panic on empty mention" \
  --body "Fixes panic when bot is mentioned with no text or nickname syntax."